Add basic support for parsing multipart/form-data fetch responses#1054
Merged
rbri merged 1 commit intoHtmlUnit:masterfrom Oct 30, 2025
Merged
Add basic support for parsing multipart/form-data fetch responses#1054rbri merged 1 commit intoHtmlUnit:masterfrom
rbri merged 1 commit intoHtmlUnit:masterfrom
Conversation
This was referenced Oct 29, 2025
Member
|
@das7pad thanks for that. This is just in time and a great motivation. Have started some days ago with writing some fetch test to start a real impl (not that polyfill) for fetch. Will take your request her more as a motivation to finish that (hopefully with the 4.19.0 release. Will have a look at this and maybe squezze it into 4.18.0. |
Member
|
Merged, adjusted, and some HtmlUnit fixes done. Your case passes now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
For jenkinsci/jenkins#11177 we need basic support for
multipart/form-dataresponses. I would like to contribute a simple implementation for it. It only handles the happy path well. Based on mozilla/rhino#1941, I take that a proper Fetch API implementation is planned for the long-term.Testing:
src/main/resources/org/htmlunit/javascript/polyfill/fetch/fetch.umd.jsinto the dev-tools of a browsermultipart/form-dataresponse from the testsIt asserts that the two parts are properly parsed and prints them: